CLDSRV-895: ListParts return part checksum by leif-scality · Pull Request #6160 · scality/cloudserver

leif-scality · 2026-04-23T10:29:31Z

Return part checksum in ListParts

claude · 2026-04-23T10:32:59Z

    "@hapi/joi": "^17.1.1",
    "@smithy/node-http-handler": "^3.0.0",
-    "arsenal": "git+https://github.com/scality/Arsenal#8.3.10",
+    "arsenal": "git+https://github.com/scality/Arsenal#improvement/ARSN-575-forward-part-checksum-for-list-parts",


Arsenal is pinned to a branch (improvement/ARSN-575-forward-part-checksum-for-list-parts) instead of a version tag. Git-based dependencies must pin to a tag for reproducible builds.

suggestion "arsenal": "git+https://github.com/scality/Arsenal#8.3.11", 

— Claude Code

claude · 2026-04-23T10:33:04Z

Arsenal dependency is pinned to a feature branch instead of a version tag — must be updated to a tag (e.g. 8.3.11) before merge for reproducible builds.

Review by Claude Code

claude · 2026-04-23T10:34:35Z

    "@hapi/joi": "^17.1.1",
    "@smithy/node-http-handler": "^3.0.0",
-    "arsenal": "git+https://github.com/scality/Arsenal#8.3.10",
+    "arsenal": "git+https://github.com/scality/Arsenal#improvement/ARSN-575-forward-part-checksum-for-list-parts",


Arsenal is pinned to a branch instead of a tag. Per project policy, git-based dependencies must be pinned to a tag (e.g. 8.3.11), not a branch.

suggestion "arsenal": "git+https://github.com/scality/Arsenal#8.3.11", 

— Claude Code

claude · 2026-04-23T10:34:41Z

Arsenal dependency is pinned to a branch (improvement/ARSN-575-forward-part-checksum-for-list-parts) instead of a tag
- Pin to a released tag (e.g. 8.3.11) before merging

Review by Claude Code

codecov · 2026-04-23T10:37:22Z

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.05%. Comparing base (3f5975c) to head (ba4d20e).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/api/listParts.js	95.45%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/services.js	`87.43% <ø> (+0.26%)`	⬆️
lib/api/listParts.js	`92.30% <95.45%> (+2.40%)`	⬆️

... and 1 file with indirect coverage changes

@@                                       Coverage Diff                                       @@
##           improvement/CLDSRV-892-store-checksum-in-part-shadow-object    #6160      +/-   ##
===============================================================================================
+ Coverage                                                        84.96%   85.05%   +0.08%     
===============================================================================================
  Files                                                              207      207              
  Lines                                                            13759    13777      +18     
===============================================================================================
+ Hits                                                             11691    11718      +27     
+ Misses                                                            2068     2059       -9

Flag	Coverage Δ
file-ft-tests	`68.78% <86.36%> (+0.02%)`	⬆️
kmip-ft-tests	`28.09% <4.54%> (-0.03%)`	⬇️
mongo-v0-ft-tests	`69.93% <86.36%> (+0.02%)`	⬆️
mongo-v1-ft-tests	`70.00% <86.36%> (+0.07%)`	⬆️
multiple-backend	`36.35% <4.54%> (-0.05%)`	⬇️
sur-tests	`35.39% <4.54%> (-0.04%)`	⬇️
sur-tests-inflights	`37.30% <4.54%> (-0.05%)`	⬇️
unit	`71.52% <95.45%> (+0.05%)`	⬆️
utapi-v2-tests	`34.57% <4.54%> (-0.20%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

claude · 2026-04-23T10:46:23Z

    "@hapi/joi": "^17.1.1",
    "@smithy/node-http-handler": "^3.0.0",
-    "arsenal": "git+https://github.com/scality/Arsenal#8.3.10",
+    "arsenal": "git+https://github.com/scality/Arsenal#improvement/ARSN-575-forward-part-checksum-for-list-parts",


Arsenal is pinned to a branch, not a tag. Git-based deps must pin to a tag for reproducible builds.

— Claude Code

claude · 2026-04-23T10:46:31Z

+        UploadId: uploadId,
+    }));
+    const part = listRes.Parts.find(part => part.PartNumber === partNumber);
+    assert(part, `Expected part ${partNumber} in ListParts response`);


Variable shadowing: the inner part parameter shadows the outer const part declaration. Use a different name like p or found.

— Claude Code

claude · 2026-04-23T10:46:40Z

Arsenal dependency is pinned to a branch (improvement/ARSN-575-forward-part-checksum-for-list-parts) instead of a tag. Git-based deps must pin to a tag for reproducible builds.
- Pin to the released tag (e.g. 8.3.11) before merging.
- Variable shadowing in mpuUploadPartChecksum.js: const part = listRes.Parts.find(part => ...) shadows the outer part.
- Rename the callback parameter to avoid shadowing.

Review by Claude Code

claude · 2026-04-23T10:50:30Z

    "@hapi/joi": "^17.1.1",
    "@smithy/node-http-handler": "^3.0.0",
-    "arsenal": "git+https://github.com/scality/Arsenal#8.3.10",
+    "arsenal": "git+https://github.com/scality/Arsenal#improvement/ARSN-575-forward-part-checksum-for-list-parts",


Arsenal is pinned to a branch, not a tag. Git-based dependencies must pin to a release tag for reproducible builds.

suggestion "arsenal": "git+https://github.com/scality/Arsenal#8.3.11", 

— Claude Code

claude · 2026-04-23T10:50:36Z

Arsenal dependency is pinned to a feature branch instead of a release tag. Pin to tag 8.3.11 (or the appropriate release) before merging.
- Update package.json and regenerate yarn.lock with the tagged version.

Review by Claude Code

leif-scality force-pushed the improvement/CLDSRV-892-store-checksum-in-part-shadow-object branch from b9b6b70 to 3f5975c Compare April 23, 2026 10:30

leif-scality added 2 commits April 23, 2026 12:30

TMP bump arsenal

50b3705

CLDSRV-895: ListParts return part checksums

0d730f5

leif-scality force-pushed the improvement/CLDSRV-895-list-parts-return-checksum branch from e70ef55 to 0d730f5 Compare April 23, 2026 10:31

claude Bot reviewed Apr 23, 2026

View reviewed changes

CLDSRV-895: verify UploadPart stores the correct checksum with ListParts

ba4d20e

leif-scality force-pushed the improvement/CLDSRV-895-list-parts-return-checksum branch from b7f26b1 to ba4d20e Compare April 23, 2026 10:48

claude Bot reviewed Apr 23, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLDSRV-895: ListParts return part checksum#6160

CLDSRV-895: ListParts return part checksum#6160
leif-scality wants to merge 3 commits intoimprovement/CLDSRV-892-store-checksum-in-part-shadow-objectfrom
improvement/CLDSRV-895-list-parts-return-checksum

leif-scality commented Apr 23, 2026

Uh oh!

claude Bot Apr 23, 2026

Uh oh!

claude Bot commented Apr 23, 2026

Uh oh!

claude Bot Apr 23, 2026

Uh oh!

claude Bot commented Apr 23, 2026

Uh oh!

codecov Bot commented Apr 23, 2026 •

edited

Loading

Uh oh!

claude Bot Apr 23, 2026

Uh oh!

claude Bot Apr 23, 2026

Uh oh!

claude Bot commented Apr 23, 2026

Uh oh!

claude Bot Apr 23, 2026

Uh oh!

claude Bot commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

leif-scality commented Apr 23, 2026

Uh oh!

claude Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Apr 23, 2026

Uh oh!

claude Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Apr 23, 2026

Uh oh!

codecov Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

claude Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Apr 23, 2026

Uh oh!

claude Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

codecov Bot commented Apr 23, 2026 •

edited

Loading