Conversation
TMT/FMF plans for C11S and RHEL11. As c11s and RHEL11 compose are not available yet let's use for now CentOS Stream 10 and RHEL10. Later on we can easily update only compose. Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
📝 WalkthroughWalkthroughGitHub Actions workflow expands the job matrix to include testing on new OS targets Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsTimed out fetching pipeline failures after 30000ms Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request validationFailed🔴 Failed or pending statuses:
🔴 Review - Missing review from a member (1 required) |
pkhartsk
requested changes
Apr 15, 2026
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/container-tests.yml (1)
35-57: Fail fast for unknown OS values instead of implicit fallback.Both inner
elsebranches currently assume the final known OS (c11s/rhel11). That works today, but a future typo or new matrix value would be silently misrouted. Prefer explicit branches plus a terminal error path.♻️ Proposed hardening
- elif [ "${{ matrix.os }}" == "c10s" ]; then + elif [ "${{ matrix.os }}" == "c10s" ]; then compose="CentOS-Stream-10" context="CentOS Stream 10" tmt_plan="/c10s" - else + elif [ "${{ matrix.os }}" == "c11s" ]; then # TODO - update compose and context for c11s when it will be available in Testing Farm compose="CentOS-Stream-10" context="CentOS Stream 11" tmt_plan="/c11s" + else + echo "Unsupported OS in public scope: ${{ matrix.os }}" >&2 + exit 1 fi else if [ "${{ matrix.os }}" == "rhel8" ]; then compose="RHEL-8.10.0-Nightly" context="RHEL8" tmt_plan="/rhel8-docker$" elif [ "${{ matrix.os }}" == "rhel9" ]; then compose="RHEL-9.6.0-Nightly" context="RHEL9" tmt_plan="/rhel9-docker$" elif [ "${{ matrix.os }}" == "rhel10" ]; then compose="RHEL-10-Nightly" context="RHEL10" tmt_plan="/rhel10-docker$" - else + elif [ "${{ matrix.os }}" == "rhel11" ]; then # TODO - update compose and context for rhel11 when it will be available in Testing Farm compose="RHEL-10-Nightly" context="RHEL11" tmt_plan="/rhel11-docker$" + else + echo "Unsupported OS in private scope: ${{ matrix.os }}" >&2 + exit 1 fi fiAlso applies to: 59-76
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/container-tests.yml around lines 35 - 57, The OS branch logic currently falls through to a default that implicitly treats unknown values as 'c11s'/'rhel11'; update the conditional in the block handling matrix.os (the branches that set compose, context, tmt_plan and api_key/branch/tf_scope/tmt_repo) to include explicit elif cases for "c11s" (and "rhel11" in the other similar block) and replace the final else with a terminal error path that echoes "Unknown OS: ${ matrix.os }" and exits non-zero; apply the same explicit branching + fatal-else change to the second occurrence (the similar block at lines referenced in the comment) so any unrecognized matrix.os fails fast instead of silently falling back.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/container-tests.yml:
- Around line 35-57: The OS branch logic currently falls through to a default
that implicitly treats unknown values as 'c11s'/'rhel11'; update the conditional
in the block handling matrix.os (the branches that set compose, context,
tmt_plan and api_key/branch/tf_scope/tmt_repo) to include explicit elif cases
for "c11s" (and "rhel11" in the other similar block) and replace the final else
with a terminal error path that echoes "Unknown OS: ${ matrix.os }" and exits
non-zero; apply the same explicit branching + fatal-else change to the second
occurrence (the similar block at lines referenced in the comment) so any
unrecognized matrix.os fails fast instead of silently falling back.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ad62fe56-65f4-463a-bbfe-f81806dd8d7a
📒 Files selected for processing (1)
.github/workflows/container-tests.yml
Member
Author
|
[test] |
Testing Farm results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable building and testing container-common-scripts with
TMT/FMF plans for C11S and RHEL11.
As c11s and RHEL11 compose are not available yet
let's use for now CentOS Stream 10 and RHEL10.
Later on we can easily update only compose.
This pull request block #423
Summary by CodeRabbit