bfd: fix ConditionalField condition for optional_auth always being True#4965
Merged
gpotter2 merged 1 commit intosecdev:masterfrom Apr 12, 2026
Merged
Conversation
…ue (secdev#4937) The condition `pkt.flags.names[2] == "A"` always evaluated to True because FlagValue.names returns the flag definition string "MDACFP", not the set of currently active flags. Replace with `pkt.flags.A` to properly check the Authentication Present bit.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4965 +/- ##
=======================================
Coverage 80.30% 80.31%
=======================================
Files 379 379
Lines 93164 93181 +17
=======================================
+ Hits 74820 74840 +20
+ Misses 18344 18341 -3
🚀 New features to boost your workflow:
|
polybassa
approved these changes
Apr 12, 2026
Member
|
Thanks for the PR ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4937
ConditionalFieldguardingoptional_authinBFDusedpkt.flags.names[2] == "A", which always evaluates toTruebecauseFlagValue.namesreturns the flag definition string"MDACFP", not the set of currently active flagspkt.flags.Ato properly check the Authentication Present bit, consistent with the pattern used elsewhere in Scapy (e.g.,vxlan.py)Test plan