Make most namespace-scope operators hidden friends#825
Merged
fabianbs96 merged 7 commits intosecure-software-engineering:developmentfrom Apr 17, 2026
Merged
Conversation
vulder
requested changes
Apr 12, 2026
| bool operator<(const DOTNode &Lhs, const DOTNode &Rhs); | ||
| bool operator==(const DOTNode &Lhs, const DOTNode &Rhs); | ||
| llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, const DOTNode &Node); | ||
| friend bool operator<(const DOTNode &Lhs, const DOTNode &Rhs); |
Collaborator
There was a problem hiding this comment.
Note: without a direct implementation this is not a hidden friend 😉
Please double check where it could make sense to move the impl. otherwise, keeping the free function is fine.
Member
Author
There was a problem hiding this comment.
Oh, wasn't aware of that^^.
Thanks!
Apparently, some compiler versions do not export hidden friends with C++20 modules...
fabianbs96
merged commit 201012b
into
secure-software-engineering:development
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.