[Fix #1296] Prevent double loading of the same process instance#1297
Merged
ricardozanini merged 1 commit intoserverlessworkflow:mainfrom Apr 10, 2026
Merged
[Fix #1296] Prevent double loading of the same process instance#1297ricardozanini merged 1 commit intoserverlessworkflow:mainfrom
ricardozanini merged 1 commit intoserverlessworkflow:mainfrom
Conversation
…ess instance Signed-off-by: fjtirado <ftirados@redhat.com>
fjtirado
commented
Apr 10, 2026
| try (Stream<WorkflowInstance> stream = handlers.reader().scanAll(definition)) { | ||
| assertThat(stream.count()).isEqualTo(1); | ||
| } | ||
| definition.close(); |
Collaborator
Author
There was a problem hiding this comment.
The fact that I have to do this in order the test to work, it is enough proof that the change is working.
If the instance map is not clear, then the instance is reused and none of the methods are invoked, failing the test.
ricardozanini
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1296