Skip to content

Fix LT-22492: Change field name to Use Abbreviation for Value #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmaxwell3 merged 1 commit into from
Apr 20, 2026
+10 −2
Merged

Fix LT-22492: Change field name to Use Abbreviation for Value #845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DistFiles/Language Explorer/Configuration/Parts/Morphology.fwlayout
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@
</part>
<part ref="DescriptionAllA">
</part>
<part ref="ShowInGloss" label="Use Abbreviation as label" abbr="sig"/>
<part ref="ShowInGloss" label="Use Abbreviation for value" abbr="sig"/>
</layout>

<layout class="FsClosedFeature" type="detail" name="Edit">
Expand All @@ -311,7 +311,7 @@
</part>
<part ref="DescriptionAllA">
</part>
<part ref="ShowInGloss" label="Use Abbreviation as label" abbr="sig"/>
<part ref="ShowInGloss" label="Use Abbreviation for value" abbr="sig"/>
</layout>

<layout class="FsClosedFeature" type="detail" name="PhonEdit">
Expand Down
3 changes: 3 additions & 0 deletions DistFiles/Language Explorer/Configuration/Parts/MorphologyParts.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1980,6 +1980,9 @@
<part id="FsFeatDefn-Detail-ShowInGloss" type="Detail">
<slice field="ShowInGloss" label="ShowInGloss" editor="Checkbox" tooltip="When displaying the values for this feature, include a label (the Feature Abbreviation) as well"/>
</part>
<part id="FsSymFeatVal-Detail-ShowInGloss" type="Detail">
<slice field="ShowInGloss" label="ShowInGloss" editor="Checkbox" tooltip="Display this feature value as its Abbreviation (instead of as its Name)"/>
</part>
</bin>
<bin class="FsComplexFeature">
<part id="FsComplexFeature-Jt-SpecialNote" type="jtview">
Expand Down
5 changes: 5 additions & 0 deletions Src/FdoUi/FdoUiCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,11 @@ internal static CmObjectUi DefaultCreateNewUiObject(Mediator mediator, int class
{
int newHvo = cache.DomainDataByFlid.MakeNewObject(classId, hvoOwner, flid, insertionPosition);
newUiObj = MakeUi(cache, newHvo, classId);
if (newUiObj?.Object is IFsSymFeatVal featVal)
{
// Default to Use Abbreviation for value.
featVal.ShowInGloss = true;
}
});
return newUiObj;
}
Expand Down
Loading