Use Gradle lazy properties for WireExtension API#3570
Open
Use Gradle lazy properties for WireExtension API#3570
Conversation
2ec8ec0 to
88a9449
Compare
JakeWharton
approved these changes
Apr 20, 2026
Collaborator
JakeWharton
left a comment
There was a problem hiding this comment.
Still can break people. Kotlin-based Gradle plugins will no longer be able to do = whevs.
| } | ||
|
|
||
| fun permitPackageCycles() = permitPackageCycles | ||
| fun permitPackageCycles() = permitPackageCycles.get() |
Collaborator
There was a problem hiding this comment.
Suggested change
| fun permitPackageCycles() = permitPackageCycles.get() | |
| fun permitPackageCycles() = permitPackageCycles.set(true) |
| } | ||
|
|
||
| fun loadExhaustively() = loadExhaustively | ||
| fun loadExhaustively() = loadExhaustively.get() |
Collaborator
There was a problem hiding this comment.
Suggested change
| fun loadExhaustively() = loadExhaustively.get() | |
| fun loadExhaustively() = loadExhaustively.set(true) |
Member
Author
There was a problem hiding this comment.
It was a getter before, why do we wanna change it to a setter?
Member
Author
|
Stuff like this are in to not break existing consumers. Are you referring to people setting up the Wire plugin in code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3543
Should not be breaking current callers