Skip to content

Use Gradle lazy properties for WireExtension API#3570

Open
oldergod wants to merge 1 commit intomasterfrom
bquenaudon.2026-04-15.lazy
Open

Use Gradle lazy properties for WireExtension API#3570
oldergod wants to merge 1 commit intomasterfrom
bquenaudon.2026-04-15.lazy

Conversation

@oldergod
Copy link
Copy Markdown
Member

Fixes #3543

Should not be breaking current callers

@oldergod oldergod force-pushed the bquenaudon.2026-04-15.lazy branch from 2ec8ec0 to 88a9449 Compare April 16, 2026 10:01
@oldergod oldergod marked this pull request as ready for review April 16, 2026 10:02
Copy link
Copy Markdown
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still can break people. Kotlin-based Gradle plugins will no longer be able to do = whevs.

}

fun permitPackageCycles() = permitPackageCycles
fun permitPackageCycles() = permitPackageCycles.get()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fun permitPackageCycles() = permitPackageCycles.get()
fun permitPackageCycles() = permitPackageCycles.set(true)

}

fun loadExhaustively() = loadExhaustively
fun loadExhaustively() = loadExhaustively.get()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fun loadExhaustively() = loadExhaustively.get()
fun loadExhaustively() = loadExhaustively.set(true)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a getter before, why do we wanna change it to a setter?

@oldergod
Copy link
Copy Markdown
Member Author

Stuff like this are in to not break existing consumers. Are you referring to people setting up the Wire plugin in code?

  /** For Groovy DSL assignment: `protoLibrary = true`. */
  fun setProtoLibrary(value: Boolean) {
    protoLibrary.set(value)
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Gradle lazy properties for WireExtension API

2 participants