Open
Conversation
5 tasks
Comment on lines
+47
to
+51
| if name.startswith(cls._PREFIX): | ||
| name = name[len(cls._PREFIX):] | ||
| if name.endswith(cls._TOTAL_SUFFIX): | ||
| name = name[:-len(cls._TOTAL_SUFFIX)] | ||
| return name |
Contributor
There was a problem hiding this comment.
Suggested change
| if name.startswith(cls._PREFIX): | |
| name = name[len(cls._PREFIX):] | |
| if name.endswith(cls._TOTAL_SUFFIX): | |
| name = name[:-len(cls._TOTAL_SUFFIX)] | |
| return name | |
| return name.removeprefix(cls._PREFIX).removesuffix(cls._TOTAL_SUFFIX) |
| if len(parts) >= 2: | ||
| dropped_count = int(parts[1]) | ||
| break | ||
| ss = metrics.snapshot() |
Contributor
There was a problem hiding this comment.
[ultra nit] I don't like ss. I guess the the less a variable is used the shorter it can be, but I would still prefer metric_snapshot here.
Contributor
|
Please rebase and remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the work on rate limiting tests in #499, I thought it might be useful to have a metrics fixture to get a snapshot of the metrics to reason about Fact's state.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI is enough.