Honour --config-dir when loading/saving defaults.#2510
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures the CLI honors --config-dir when reading and writing config.toml defaults (network/identity/inclusion fee), aligning startup behavior and “use” commands with the selected config profile.
Changes:
- Add path-aware
Config::load/Config::save_tohelpers and routenew()/save()through them. - Update default write/unset helpers to read/write
config.tomlunder the active config dir. - Update startup env-default loading to prefer
--config-dir(parsed from raw args) and add integration tests covering both startup reads and default writes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/soroban-cli/src/config/mod.rs | Introduces path-based load/save helpers to support non-global config locations. |
| cmd/soroban-cli/src/config/locator.rs | Writes/unsets defaults using a config.toml path derived from the active config dir. |
| cmd/soroban-cli/src/cli.rs | Startup defaults loading now honors --config-dir by scanning raw CLI args before clap parsing. |
| cmd/crates/soroban-test/tests/it/config.rs | Adds integration tests ensuring --config-dir affects startup defaults and where defaults are written. |
leighmcculloch
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Honour --config-dir when loading/saving defaults.
Why
Known limitations
N/A