fix: Give nested groups readable names#265
Closed
nielsbasjes wants to merge 1 commit intosunspec:masterfrom
Closed
fix: Give nested groups readable names#265nielsbasjes wants to merge 1 commit intosunspec:masterfrom
nielsbasjes wants to merge 1 commit intosunspec:masterfrom
Conversation
Contributor
|
Hi @nielsbasjes, a lot of SunSpec Modbus implementations use the 'name' attribute in their code like 705.Crv.Pt[1].V. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating code from the SunSpec models it is very useful to have a name for the subgroups that is a bit easier to understand.