Skip to content

fix(mcp): add return after t.Fatal to satisfy staticcheck SA5011 #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greynewell merged 1 commit into from
Apr 21, 2026
+3 −0
Merged

fix(mcp): add return after t.Fatal to satisfy staticcheck SA5011 #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/mcp/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ func TestDispatch_UnknownMethod(t *testing.T) {
_, rpcErr := s.dispatch(context.Background(), "unknown/method", nil)
if rpcErr == nil {
t.Fatal("expected rpcError for unknown method")
return
}
if rpcErr.Code != codeMethodNotFound {
t.Errorf("expected codeMethodNotFound (%d), got %d", codeMethodNotFound, rpcErr.Code)
Expand All @@ -325,6 +326,7 @@ func TestDispatch_ToolsCall_UnknownTool(t *testing.T) {
_, rpcErr := s.dispatch(context.Background(), "tools/call", params)
if rpcErr == nil {
t.Fatal("expected rpcError for unknown tool name in tools/call")
return
}
if rpcErr.Code != codeInternalError {
t.Errorf("expected codeInternalError (%d), got %d", codeInternalError, rpcErr.Code)
Expand Down Expand Up @@ -566,6 +568,7 @@ func TestHandleToolCall_ParseError(t *testing.T) {
_, rpcErr := s.handleToolCall(context.Background(), badParams)
if rpcErr == nil {
t.Fatal("expected rpcError for invalid params JSON")
return
}
if rpcErr.Code != codeParseError {
t.Errorf("expected codeParseError (%d), got %d", codeParseError, rpcErr.Code)
Expand Down
Loading