Merged
Conversation
tbenthompson
approved these changes
Aug 7, 2025
Owner
tbenthompson
left a comment
tbenthompson
left a comment
There was a problem hiding this comment.
nice! thanks. any opinions on whether it's worth migrating off distutils at some point?
|
Hey, While you approved the changes, it seems the code was not integrated yet, any plan on doing it? We don't see the logs to understand what happened. You can by the way add python 3.11 12 13 to the github actions. I can contribute if needed to get these changes integrated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.12 removed distutils. Setuptools is a current alternative.
Setuptools contains undocumented submodule _distutils for backward compatibility.
This hotfix uses distutils if run on Python 3.11 and older and setuptools._distutils otherwise.