Skip to content

🎨 Palette: Make custom div buttons accessible on welcome screen#52

Open
thirdeyenation wants to merge 1 commit intomainfrom
palette-welcome-a11y-11083504222213058978
Open

🎨 Palette: Make custom div buttons accessible on welcome screen#52
thirdeyenation wants to merge 1 commit intomainfrom
palette-welcome-a11y-11083504222213058978

Conversation

@thirdeyenation
Copy link
Copy Markdown
Owner

💡 What

Added ARIA roles, tabindex, keyboard event handlers, and focus-visible styles to the .welcome-action-card elements on the welcome screen.

🎯 Why

These elements look and act like buttons, but were marked up as regular divs. This meant keyboard users and screen reader users could not interact with them. This change makes the welcome screen fully accessible and usable for all users.

♿ Accessibility

  • Added role="button" to provide semantic meaning for screen readers.
  • Added tabindex="0" to make the elements focusable via keyboard navigation.
  • Added @keydown.enter and @keydown.space.prevent event handlers so keyboard users can activate the actions.
  • Added :focus-visible styles (matching the existing hover state + an outline) so keyboard users have clear visual feedback when an element is focused.

PR created automatically by Jules for task 11083504222213058978 started by @thirdeyenation

- Added `role="button"` and `tabindex="0"` to `.welcome-action-card`
- Added `@keydown.enter` and `@keydown.space.prevent` handlers
- Added `:focus-visible` styling for keyboard navigation

Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant