🎨 Palette: Make custom div buttons accessible on welcome screen#52
🎨 Palette: Make custom div buttons accessible on welcome screen#52thirdeyenation wants to merge 1 commit intomainfrom
Conversation
- Added `role="button"` and `tabindex="0"` to `.welcome-action-card` - Added `@keydown.enter` and `@keydown.space.prevent` handlers - Added `:focus-visible` styling for keyboard navigation Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Added ARIA roles, tabindex, keyboard event handlers, and
focus-visiblestyles to the.welcome-action-cardelements on the welcome screen.🎯 Why
These elements look and act like buttons, but were marked up as regular
divs. This meant keyboard users and screen reader users could not interact with them. This change makes the welcome screen fully accessible and usable for all users.♿ Accessibility
role="button"to provide semantic meaning for screen readers.tabindex="0"to make the elements focusable via keyboard navigation.@keydown.enterand@keydown.space.preventevent handlers so keyboard users can activate the actions.:focus-visiblestyles (matching the existing hover state + an outline) so keyboard users have clear visual feedback when an element is focused.PR created automatically by Jules for task 11083504222213058978 started by @thirdeyenation