Fix Buffer<T>.GrowBuffer() using wrong variable for allocation size#104
Open
Beldaa wants to merge 1 commit intotoptensoftware:mainfrom
Open
Fix Buffer<T>.GrowBuffer() using wrong variable for allocation size#104Beldaa wants to merge 1 commit intotoptensoftware:mainfrom
Beldaa wants to merge 1 commit intotoptensoftware:mainfrom
Conversation
GrowBuffer() calculated an optimal capacity in ewLength (doubling below 1MB, linear growth above) but then allocated the new array with equiredLength instead, making the growth strategy dead code. This caused O(n) reallocations instead of O(log n), degrading sequential Add/Insert operations from O(n) amortized to O(n²).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103
Summary
GrowBuffer()calculated an optimal capacity innewLength(doubling below 1MB, linear growth above) but then allocated the new array withrequiredLengthinstead, making the entire growth strategy dead code. This caused O(n) reallocations instead of O(log n), degrading sequential Add/Insert operations from O(n) amortized to O(n^2).Change
One-line fix in
Buffer.csline 113:var newData = new T[requiredLength];var newData = new T[newLength];Affected components
Buffer is used throughout the library: BiDi algorithm, text shaping, Utf32Buffer, and TextDocument. Any non-trivial text processing benefits from this fix.