Fix StyleManager cache key using nullable parameter instead of resolved value#108
Open
Beldaa wants to merge 1 commit intotoptensoftware:mainfrom
Open
Fix StyleManager cache key using nullable parameter instead of resolved value#108Beldaa wants to merge 1 commit intotoptensoftware:mainfrom
Beldaa wants to merge 1 commit intotoptensoftware:mainfrom
Conversation
…ed value The style cache key used fontWidth (the nullable parameter, often null) instead of rFontWidth (the resolved value). This caused styles with different font widths to collide in the cache, returning incorrect styles.
Beldaa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107