Fix overriding of C++11's std::swap function#236
Open
LoganjdM wants to merge 1 commit intotsoding:mainfrom
Open
Fix overriding of C++11's std::swap function#236LoganjdM wants to merge 1 commit intotsoding:mainfrom
LoganjdM wants to merge 1 commit intotsoding:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the nob_swap macro from v1.25.0 redefines
std::swap()causing a nasty (standard) long compile error about incorrect arguments to std::swap() in other C++ stdlib headers since C++ isbadgood.I think simply having a conditional at the end of the
NOB_STRIP_PREFIXis best, unless there's a point else where we deal with un-definitions of macros I didn't spot- minor issue really.