Open
Conversation
…ict return minor lint/format fixes in ifutil.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add initial logging. Currently only for network related functionality in
confconsole.More tweaks are required to Confconsole for IPv6 and cleanly handling DHCP (now we've switched to
dhcpcd). Those changes will be in another PR, but I wanted to be able to easily troubleshoot and/or confirm it's working as intended but I wanted to separate the initial logging setup (and the minor linting updates) in their own PR.Further extending Confconsole logging is probably desirable but low priority for now IMO.
Specific changes:
ifutil.py- d6bbfb6