Skip to content

Costs dataclass#4196

Open
clmould wants to merge 2 commits intomainfrom
Costs-Dataclass
Open

Costs dataclass#4196
clmould wants to merge 2 commits intomainfrom
Costs-Dataclass

Conversation

@clmould
Copy link
Copy Markdown
Collaborator

@clmould clmould commented Apr 16, 2026

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 94.35484% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.73%. Comparing base (b9e97d7) to head (5ae17bf).

Files with missing lines Patch % Lines
process/models/availability.py 87.77% 11 Missing ⚠️
process/core/solver/constraints.py 50.00% 6 Missing ⚠️
process/core/scan.py 0.00% 4 Missing ⚠️
process/models/costs/costs_2015.py 63.63% 4 Missing ⚠️
process/core/solver/objectives.py 40.00% 3 Missing ⚠️
process/core/solver/evaluators.py 0.00% 2 Missing ⚠️
process/models/ife.py 33.33% 2 Missing ⚠️
process/core/caller.py 0.00% 1 Missing ⚠️
process/core/final.py 0.00% 1 Missing ⚠️
process/main.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4196      +/-   ##
==========================================
- Coverage   52.10%   51.73%   -0.38%     
==========================================
  Files         148      148              
  Lines       30389    30143     -246     
==========================================
- Hits        15835    15593     -242     
+ Misses      14554    14550       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clmould clmould marked this pull request as ready for review April 16, 2026 16:25
@clmould clmould requested a review from a team as a code owner April 16, 2026 16:25
Comment thread process/main.py
Comment thread process/main.py
return self._costs_2015
if data_structure.cost_variables.cost_model == 2:
if self.data.costs.cost_model == 2:
if self._costs_custom is not None:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that these changes work for custom cost models?

@je-cook je-cook added the Data structure Issues related to the data structure label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants