Skip to content

4183 improve the representation of neutral beam tangency in the toroidal cross section plotting#4199

Merged
je-cook merged 8 commits intomainfrom
4183-improve-the-representation-of-neutral-beam-tangency-in-the-toroidal-cross-section-plotting
Apr 20, 2026
Merged

4183 improve the representation of neutral beam tangency in the toroidal cross section plotting#4199
je-cook merged 8 commits intomainfrom
4183-improve-the-representation-of-neutral-beam-tangency-in-the-toroidal-cross-section-plotting

Conversation

@grmtrkngtn
Copy link
Copy Markdown
Collaborator

@grmtrkngtn grmtrkngtn commented Apr 17, 2026

Description

Revamps beam tangency plotting, fixes a few geometry accounting errors.
Fix NBI duct plotting by using shielded TF width and constructing the beam edges and centreline consistently from tangent geometry.
This ensures the duct is symmetric about the true beam centreline and aligns with the PROCESS docs.

  • Adds a centre-line to beam duct plotting.

result:
image

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

…ct beam edges and centreline using tangent-to-circle geometry with shielded TF width, ensuring symmetric duct about the centreline.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 17, 2026

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.06%. Comparing base (4c99916) to head (82b7056).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
process/core/io/plot/summary.py 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4199      +/-   ##
==========================================
- Coverage   52.07%   52.06%   -0.02%     
==========================================
  Files         148      148              
  Lines       30321    30324       +3     
==========================================
- Hits        15791    15789       -2     
- Misses      14530    14535       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread process/core/io/plot/summary.py Outdated
Comment thread process/core/io/plot/summary.py Outdated
Comment thread process/core/io/plot/summary.py Outdated
@je-cook je-cook self-assigned this Apr 20, 2026
Comment thread process/core/io/plot/summary.py Outdated
Comment thread process/core/io/plot/summary.py Outdated
@je-cook je-cook enabled auto-merge (squash) April 20, 2026 10:01
@je-cook je-cook merged commit 552be84 into main Apr 20, 2026
10 of 11 checks passed
@je-cook je-cook deleted the 4183-improve-the-representation-of-neutral-beam-tangency-in-the-toroidal-cross-section-plotting branch April 20, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the representation of neutral beam tangency in the toroidal cross-section plotting.

3 participants