Conversation
…ct beam edges and centreline using tangent-to-circle geometry with shielded TF width, ensuring symmetric duct about the centreline.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4199 +/- ##
==========================================
- Coverage 52.07% 52.06% -0.02%
==========================================
Files 148 148
Lines 30321 30324 +3
==========================================
- Hits 15791 15789 -2
- Misses 14530 14535 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
je-cook
requested changes
Apr 20, 2026
je-cook
reviewed
Apr 20, 2026
je-cook
reviewed
Apr 20, 2026
…eam-tangency-in-the-toroidal-cross-section-plotting
je-cook
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revamps beam tangency plotting, fixes a few geometry accounting errors.
Fix NBI duct plotting by using shielded TF width and constructing the beam edges and centreline consistently from tangent geometry.
This ensures the duct is symmetric about the true beam centreline and aligns with the PROCESS docs.
result:

Checklist
I confirm that I have completed the following checks: