Open
Conversation
…reactivity from beam-fusion. re-documented functions more explicitly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4200 +/- ##
==========================================
+ Coverage 52.07% 52.11% +0.03%
==========================================
Files 148 148
Lines 30321 30382 +61
==========================================
+ Hits 15791 15834 +43
- Misses 14530 14548 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
je-cook
requested changes
Apr 20, 2026
Collaborator
je-cook
left a comment
There was a problem hiding this comment.
Just comments on code and docstrings. I havent reviewed the model changes
je-cook
reviewed
Apr 20, 2026
je-cook
approved these changes
Apr 20, 2026
Collaborator
je-cook
left a comment
There was a problem hiding this comment.
Codewise happy, leaving the model thoughts to @chris-ashe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored beam_fusion model.
The model now directly computes beam alpha power from:
The previous thermal reactivity correction (Bosch-Hale) has been removed.
This was not physically consistent:
thermal fusion involves two Maxwellian populations
beam-target fusion involves one fast population and one thermal population
the beam reactivity already includes fast-ion averaging
See the docs for outline of the routine. I haven't changed much else of the physics but it's been listed more clearly in the docs in the new functional form.
Most of the changes are clarifying what each function is actually calculating and changing docstring and name accordingly.
Checklist
I confirm that I have completed the following checks: