-
Notifications
You must be signed in to change notification settings - Fork 55
Big int #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Big int #847
Changes from all commits
af321ee
3137084
b5c7447
bd14576
acfeae1
07358a5
909d8a5
f2acd8c
602eefc
14828d9
080de0e
73e917e
ef5c779
4490a49
4c5aeb1
8137486
b87cf3a
ad89dab
5ee5d1b
38e31f4
cafb353
dbe3537
ba45e22
75a7f28
946b841
fafacee
fe3bf72
d3282bc
1761511
0e43fd4
9c3defb
ae10b94
a58547e
7315ba2
6ff2d7b
602f0cd
89013ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -333,6 +333,16 @@ public function getLimitForInt(): int | |||||||||||||||||||||||||||
| return $this->delegate(__FUNCTION__, \func_get_args()); | ||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| public function getLimitForBigInt(): int | ||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||
| return $this->delegate(__FUNCTION__, \func_get_args()); | ||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
|
Comment on lines
+336
to
+339
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Add the delegation alongside the existing
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| public function getSupportForUnsignedBigInt(): bool | ||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||
| return $this->delegate(__FUNCTION__, \func_get_args()); | ||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| public function getLimitForAttributes(): int | ||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||
| return $this->delegate(__FUNCTION__, \func_get_args()); | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -896,6 +896,16 @@ public function getLimitForInt(): int | |
| return 4294967295; | ||
| } | ||
|
|
||
| /** | ||
| * Get max BIGINT limit | ||
| * | ||
| * @return int | ||
| */ | ||
| public function getLimitForBigInt(): int | ||
| { | ||
| return Database::MAX_BIG_INT; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here going other way around |
||
| } | ||
|
ArnabChatterjee20k marked this conversation as resolved.
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| /** | ||
| * Get maximum column limit. | ||
| * https://mariadb.com/kb/en/innodb-limitations/#limitations-on-schema | ||
|
|
@@ -1164,6 +1174,10 @@ public function getAttributeWidth(Document $collection): int | |
| } | ||
| break; | ||
|
|
||
| case Database::VAR_BIGINT: | ||
| $total += 8; // BIGINT 8 bytes | ||
| break; | ||
|
|
||
| case Database::VAR_FLOAT: | ||
| $total += 8; // DOUBLE 8 bytes | ||
| break; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mongodb, postgresql, sqlite doesn't support unsigned bigint