Feat: Support multiple aliases + tests; + Removal of params#59
Conversation
Greptile SummaryThis PR upgrades the HTTP alias system from a single-alias model ( Confidence Score: 5/5Safe to merge; the only concern is a breaking public-API removal that may require a semver bump. All findings are P2. The logic change is correct and well-covered by the new e2e test. The removed $params was never forwarded to Route::alias(), so no functional regression exists. The breaking-API concern is worth noting but does not block merging by itself. src/Platform/Scope/HTTP.php — public API methods removed without a deprecation shim. Important Files Changed
Reviews (1): Last reviewed commit: "Support multiple aliases + tests; + Remo..." | Re-trigger Greptile |
| public function httpAlias(string $path): self | ||
| { | ||
| $this->httpAliasPath = $path; | ||
| $this->httpAliasParams = $params; | ||
| $this->httpAliases[] = $path; | ||
|
|
||
| return $this; | ||
| } |
There was a problem hiding this comment.
Breaking API change without deprecation
getHttpAliasPath(), getHttpAliasParams(), and the $params argument on httpAlias() are all removed in one step, with no deprecation shim. Any downstream code calling getHttpAliasPath(), getHttpAliasParams(), or httpAlias($path, $params) will throw a fatal error at runtime. If the library follows semver, this warrants at minimum a major-version bump or a temporary compatibility shim (getHttpAliasPath() returning the first element of $httpAliases, etc.) before removal.
No description provided.