Open
Conversation
Cache decompiled Java class files and rewrite jdt:// URIs in definition/typeDefinition/implementation responses to point to local file URIs instead.
Remove the unused `lsp_info!` macro import from decompile.rs and clean up verbose logging throughout the decompile and proxy code. Replace generic log messages with more specific ones where useful. Improve cache_path parsing to handle URL-encoded class names in jdt:// URIs more robustly. Set extendedClientCapabilities defaults in Java language server initialization options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a workaround to get decompiled files working within Zed.
The proxy intercepts definitions requests being returned from JDTLS with a URI starting with
jdt://and creates a temp java file which Zed is then able to read and further decompilation can happen.To work, JDTLS needs to receive additional client capabilities within the initialization options. If the user has not set such the extension will enable those by default.