Pin Viceroy install to v0.16.4 in test workflow#656
Merged
Conversation
Upstream Viceroy 0.16.6 bumped its MSRV to rustc 1.95, but this repo pins rustc 1.91.1 in rust-toolchain.toml. The test workflow installed Viceroy from HEAD, so CI picked up 0.16.6 and failed to compile with "viceroy-lib@0.16.6 requires rustc 1.95". Pin to v0.16.4, matching the tag already used by .github/actions/setup-integration-test-env/action.yml. Drop the ls-remote cache-key step since a fixed tag is now the cache key.
Adds `viceroy 0.16.4` to `.tool-versions` and rewires both the `Run Tests` workflow and the `setup-integration-test-env` composite action to read the tag from there via grep. `.tool-versions` is now the single source of truth, so the two workflows can no longer drift on the pin. The pin is still required because upstream Viceroy > v0.16.4 bumped MSRV beyond the rustc pin in rust-toolchain.toml.
ChristianPavilonis
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/test.ymlinstalled Viceroy fromHEAD. CI then started picking upviceroy-lib@0.16.6, which bumped MSRV to rustc 1.95, whilerust-toolchain.tomlpins rustc 1.91.1 — failing withviceroy-lib@0.16.6 requires rustc 1.95..tool-versionsthe single source of truth for the Viceroy pin. Bothtest.ymland.github/actions/setup-integration-test-env/action.ymlnow read the version viagrep '^viceroy ' .tool-versions, so the two workflows can no longer drift.0.16.4, the latest tag whose MSRV is compatible with this repo's rustc pin. Follow-up tracked in CI: upstream Viceroy 0.16.6 requires rustc 1.95, exceeds repo's 1.91.1 pin #657.Test plan
Run Tests / cargo testjob succeeds