Skip to content

fix: annotations in configuration section respect ignore keys list #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxy-shpfy wants to merge 1 commit into
base: 04-21-fix_history_redo_entries_display_order
Choose a base branch
from
+17 −3
Open

fix: annotations in configuration section respect ignore keys list #2113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/routes/v2/pages/Editor/components/AnnotationsBlock/AnnotationsBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,21 @@ function AnnotationRow({ annotation, index, annotations }: AnnotationRowProps) {
useAnnotationActions();

const handleUpdateKey = (event: ChangeEvent<HTMLInputElement>) => {
updateAnnotationKey(annotations, index, event.target.value);
const newKey = event.target.value;
if (newKey !== annotation.key) {
updateAnnotationKey(annotations, index, newKey);
}
};

const handleUpdateValue = (event: ChangeEvent<HTMLInputElement>) => {
updateAnnotationValue(annotations, index, String(event.target.value));
const newValue = String(event.target.value);
const currentValue =
typeof annotation.value === "object"
? JSON.stringify(annotation.value)
: String(annotation.value ?? "");
if (newValue !== currentValue) {
updateAnnotationValue(annotations, index, newValue);
}
};

const handleRemove = () => {
Expand Down
6 changes: 5 additions & 1 deletion src/routes/v2/pages/Editor/nodes/TaskNode/context/TaskDetails/TaskDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,11 @@ export const TaskDetails = observer(function TaskDetails({

<Separator />

<AnnotationsBlock annotations={task.annotations} defaultEditing />
<AnnotationsBlock
annotations={task.annotations}
defaultEditing
ignoreAnnotationKeys={EDITOR_ANNOTATION_KEYS}
/>
</BlockStack>
</TabsContent>
</Tabs>
Expand Down
Loading