Skip to content

fix: annotations in configuration section respect ignore keys list#2113

Open
maxy-shpfy wants to merge 1 commit into04-21-fix_history_redo_entries_display_orderfrom
04-21-fix_annotations_in_configuration_section_respect_ignore_keys_list
Open

fix: annotations in configuration section respect ignore keys list#2113
maxy-shpfy wants to merge 1 commit into04-21-fix_history_redo_entries_display_orderfrom
04-21-fix_annotations_in_configuration_section_respect_ignore_keys_list

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented Apr 22, 2026

Description

Annotation updates in the editor now only trigger when the value has actually changed. For key updates, the new key is compared against the existing key before calling updateAnnotationKey. For value updates, the new value is compared against the current value (with object values serialized via JSON.stringify) before calling updateAnnotationValue. This prevents unnecessary updates from firing on every input event when the content hasn't changed.

Additionally, the AnnotationsBlock in TaskDetails now receives ignoreAnnotationKeys={EDITOR_ANNOTATION_KEYS}, filtering out internal editor annotation keys from the user-facing annotations panel.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Open a task in the editor and navigate to the annotations tab.
  2. Edit an annotation key or value and confirm that updates only fire when the content has actually changed.
  3. Verify that annotation keys defined in EDITOR_ANNOTATION_KEYS are not displayed in the annotations panel.

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

🎩 Preview

A preview build has been created at: 04-21-fix_annotations_in_configuration_section_respect_ignore_keys_list/6a563af

@maxy-shpfy maxy-shpfy force-pushed the 04-21-fix_history_redo_entries_display_order branch from 66a4318 to 711cfd9 Compare April 22, 2026 06:49
@maxy-shpfy maxy-shpfy force-pushed the 04-21-fix_annotations_in_configuration_section_respect_ignore_keys_list branch from 3283a7c to 6a563af Compare April 22, 2026 06:49
@maxy-shpfy maxy-shpfy marked this pull request as ready for review April 22, 2026 06:54
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner April 22, 2026 06:54
Copy link
Copy Markdown
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue it aims to (but not other issues with the annotation editor, which I presume will be fixed separately)
It also means editor position is no longer editable for tasks - probably okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants