fix: annotations in configuration section respect ignore keys list#2113
Open
maxy-shpfy wants to merge 1 commit into04-21-fix_history_redo_entries_display_orderfrom
Conversation
🎩 PreviewA preview build has been created at: |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
66a4318 to
711cfd9
Compare
3283a7c to
6a563af
Compare
Mbeaulne
approved these changes
Apr 22, 2026
camielvs
approved these changes
Apr 22, 2026
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Annotation updates in the editor now only trigger when the value has actually changed. For key updates, the new key is compared against the existing key before calling
updateAnnotationKey. For value updates, the new value is compared against the current value (with object values serialized viaJSON.stringify) before callingupdateAnnotationValue. This prevents unnecessary updates from firing on every input event when the content hasn't changed.Additionally, the
AnnotationsBlockinTaskDetailsnow receivesignoreAnnotationKeys={EDITOR_ANNOTATION_KEYS}, filtering out internal editor annotation keys from the user-facing annotations panel.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
EDITOR_ANNOTATION_KEYSare not displayed in the annotations panel.Additional Comments