chore: remove all transport overrides from GAPIC options#16777
chore: remove all transport overrides from GAPIC options#16777jskeet wants to merge 1 commit intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the transport configuration options for several Python libraries in librarian.yaml. The review feedback identifies that these removals leave several API entries with null values, which may lead to runtime errors in the GAPIC generator. It is recommended to remove these empty entries or the entire opt_args_by_api sections where no other arguments remain to maintain a clean and functional configuration.
| python: | ||
| opt_args_by_api: | ||
| google/cloud/billing/budgets/v1: | ||
| - transport=grpc+rest |
There was a problem hiding this comment.
Removing the transport option here leaves the google/cloud/billing/budgets/v1 key with a null value in YAML. If the GAPIC generator expects a list of arguments for each API entry, this could lead to a runtime error (e.g., a TypeError when attempting to iterate over None). It is recommended to remove the empty API entries entirely if they no longer have any optional arguments. This pattern occurs in several other places in this PR, such as the compute, notebooks, tpu, videointelligence, and workflows sections.
| python: | ||
| opt_args_by_api: | ||
| google/cloud/videointelligence/v1: | ||
| - transport=grpc+rest |
There was a problem hiding this comment.
Similar to the issue noted above, removing all transport options for the videointelligence library leaves the opt_args_by_api block containing only keys with null values. If no other optional arguments are needed for these APIs, the entire opt_args_by_api section for this library should be removed to keep the configuration clean and avoid potential parsing issues in the generator.
|
Closed for now as I'd forgotten to actually regenerate with the changes - generating now, will then push the changes and reopen. |
|
Oops - accidentally created #16779 instead of reopening this. Will just leave this closed. |
1 participant
Towards googleapis/librarian#5542