Skip to content

chore: remove all transport overrides from GAPIC options #16777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jskeet wants to merge 1 commit into from
+0 −34
Closed

chore: remove all transport overrides from GAPIC options #16777

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions librarian.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,19 +784,15 @@ libraries:
google/cloud/bigquery/datapolicies/v1:
- python-gapic-namespace=google.cloud
- python-gapic-name=bigquery_datapolicies
- transport=grpc+rest
google/cloud/bigquery/datapolicies/v1beta1:
- python-gapic-namespace=google.cloud
- python-gapic-name=bigquery_datapolicies
- transport=grpc
google/cloud/bigquery/datapolicies/v2:
- python-gapic-namespace=google.cloud
- python-gapic-name=bigquery_datapolicies
- transport=grpc+rest
google/cloud/bigquery/datapolicies/v2beta1:
- python-gapic-namespace=google.cloud
- python-gapic-name=bigquery_datapolicies
- transport=grpc+rest
product_documentation_override: https://cloud.google.com/bigquery/docs/reference/bigquerydatapolicy/rest
metadata_name_override: bigquerydatapolicy
default_version: v1
Expand Down Expand Up @@ -932,9 +928,7 @@ libraries:
python:
opt_args_by_api:
google/cloud/billing/budgets/v1:
- transport=grpc+rest
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing the transport option here leaves the google/cloud/billing/budgets/v1 key with a null value in YAML. If the GAPIC generator expects a list of arguments for each API entry, this could lead to a runtime error (e.g., a TypeError when attempting to iterate over None). It is recommended to remove the empty API entries entirely if they no longer have any optional arguments. This pattern occurs in several other places in this PR, such as the compute, notebooks, tpu, videointelligence, and workflows sections.

google/cloud/billing/budgets/v1beta1:
- transport=grpc
product_documentation_override: https://cloud.google.com/billing/docs/how-to/budget-api-overview
metadata_name_override: billingbudgets
default_version: v1
Expand Down Expand Up @@ -1077,7 +1071,6 @@ libraries:
python:
opt_args_by_api:
google/cloud/compute/v1:
- transport=rest
name_pretty_override: Compute Engine
metadata_name_override: compute
default_version: v1
Expand All @@ -1089,7 +1082,6 @@ libraries:
python:
opt_args_by_api:
google/cloud/compute/v1beta:
- transport=rest
- warehouse-package-name=google-cloud-compute-v1beta
name_pretty_override: Compute Engine
product_documentation_override: https://cloud.google.com/compute/
Expand Down Expand Up @@ -1152,11 +1144,9 @@ libraries:
google/container/v1:
- python-gapic-namespace=google.cloud
- warehouse-package-name=google-cloud-container
- transport=grpc+rest
google/container/v1beta1:
- python-gapic-namespace=google.cloud
- warehouse-package-name=google-cloud-container
- transport=grpc
metadata_name_override: container
default_version: v1
- name: google-cloud-containeranalysis
Expand Down Expand Up @@ -1630,14 +1620,11 @@ libraries:
google/firestore/admin/v1:
- python-gapic-name=firestore_admin
- python-gapic-namespace=google.cloud
- transport=grpc+rest
google/firestore/bundle:
- python-gapic-namespace=google.cloud
- python-gapic-name=firestore_bundle
- transport=grpc
google/firestore/v1:
- python-gapic-namespace=google.cloud
- transport=grpc+rest
name_pretty_override: Cloud Firestore API
product_documentation_override: https://cloud.google.com/firestore
issue_tracker_override: https://issuetracker.google.com/savedsearches/5337669
Expand Down Expand Up @@ -1785,32 +1772,26 @@ libraries:
- python-gapic-name=iam_admin
- python-gapic-namespace=google.cloud
- warehouse-package-name=google-cloud-iam
- transport=grpc
google/iam/credentials/v1:
- warehouse-package-name=google-cloud-iam
- python-gapic-namespace=google.cloud
- python-gapic-name=iam_credentials
- transport=grpc+rest
google/iam/v2:
- python-gapic-name=iam
- python-gapic-namespace=google.cloud
- warehouse-package-name=google-cloud-iam
- transport=grpc+rest
google/iam/v2beta:
- python-gapic-name=iam
- python-gapic-namespace=google.cloud
- warehouse-package-name=google-cloud-iam
- transport=grpc
google/iam/v3:
- python-gapic-name=iam
- python-gapic-namespace=google.cloud
- warehouse-package-name=google-cloud-iam
- transport=grpc+rest
google/iam/v3beta:
- python-gapic-name=iam
- python-gapic-namespace=google.cloud
- warehouse-package-name=google-cloud-iam
- transport=grpc+rest
name_pretty_override: Cloud Identity and Access Management
product_documentation_override: https://cloud.google.com/iam/docs/
api_shortname_override: iamcredentials
Expand Down Expand Up @@ -2199,11 +2180,8 @@ libraries:
python:
opt_args_by_api:
google/cloud/notebooks/v1:
- transport=grpc
google/cloud/notebooks/v1beta1:
- transport=grpc+rest
google/cloud/notebooks/v2:
- transport=grpc+rest
name_pretty_override: AI Platform Notebooks
product_documentation_override: https://cloud.google.com/ai-platform/notebooks/
metadata_name_override: notebooks
Expand Down Expand Up @@ -2909,11 +2887,8 @@ libraries:
python:
opt_args_by_api:
google/cloud/tpu/v1:
- transport=grpc
google/cloud/tpu/v2:
- transport=grpc+rest
google/cloud/tpu/v2alpha1:
- transport=grpc
metadata_name_override: tpu
default_version: v1
- name: google-cloud-trace
Expand Down Expand Up @@ -3008,15 +2983,10 @@ libraries:
python:
opt_args_by_api:
google/cloud/videointelligence/v1:
- transport=grpc+rest
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the issue noted above, removing all transport options for the videointelligence library leaves the opt_args_by_api block containing only keys with null values. If no other optional arguments are needed for these APIs, the entire opt_args_by_api section for this library should be removed to keep the configuration clean and avoid potential parsing issues in the generator.

google/cloud/videointelligence/v1beta2:
- transport=grpc+rest
google/cloud/videointelligence/v1p1beta1:
- transport=grpc+rest
google/cloud/videointelligence/v1p2beta1:
- transport=grpc+rest
google/cloud/videointelligence/v1p3beta1:
- transport=grpc
name_pretty_override: Video Intelligence
product_documentation_override: https://cloud.google.com/video-intelligence/docs/
metadata_name_override: videointelligence
Expand Down Expand Up @@ -3113,13 +3083,9 @@ libraries:
python:
opt_args_by_api:
google/cloud/workflows/executions/v1:
- transport=grpc
google/cloud/workflows/executions/v1beta:
- transport=grpc
google/cloud/workflows/v1:
- transport=grpc+rest
google/cloud/workflows/v1beta:
- transport=grpc+rest
name_pretty_override: Cloud Workflows
metadata_name_override: workflows
default_version: v1
Expand Down
Loading