fix: display any validation issues including warnings in v2#2143
Open
maxy-shpfy wants to merge 1 commit into04-22-fix_track_subgraph_historyfrom
Open
Conversation
🎩 PreviewA preview build has been created at: |
This was referenced Apr 23, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 23, 2026
maxy-shpfy
force-pushed
the
04-22-fix_display_any_validation_issues_including_warnings_in_v2
branch
from
1b5f8ce to
2b1ce5e
Compare
maxy-shpfy
force-pushed
the
04-22-fix_track_subgraph_history
branch
from
f53b532 to
1c65536
Compare
maxy-shpfy
force-pushed
the
04-22-fix_display_any_validation_issues_including_warnings_in_v2
branch
from
2b1ce5e to
7420694
Compare
This was referenced Apr 23, 2026
camielvs
reviewed
Apr 24, 2026
Collaborator
camielvs
left a comment
camielvs
left a comment
There was a problem hiding this comment.
Just to confirm: are inputs with no value no longer considered as "warnings"?
camielvs
approved these changes
Apr 24, 2026
Collaborator
camielvs
left a comment
camielvs
left a comment
There was a problem hiding this comment.
this PR is good. but just curious about the above question ^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
hasValidationIssuescomputed property toComponentSpecthat returnstruewhen any validation issues exist, regardless of severity. This replaces the use ofisValidin thePipelineDetailsContentvalidations section, which was incorrectly showing the "No validation issues" success box when only warnings (non-error severity issues) were present.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments
isValidonly checks forerrorseverity issues, meaning pipelines with warnings would incorrectly display the "No validation issues" message. The newhasValidationIssuesproperty checks all issues regardless of severity to ensure accurate feedback is shown to the user.