fix: autofix navigation on subgraph create undo#2145
Open
maxy-shpfy wants to merge 1 commit into04-22-fix_windows_state_persistence_and_default_layoutfrom
Open
Conversation
🎩 PreviewA preview build has been created at: |
This was referenced Apr 23, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
When a user is navigating inside a nested subgraph and performs an undo/redo operation that removes that subgraph, the navigation path becomes invalid (i.e.,
activeSpecisnullwhile the path depth is greater than 1). This leaves the editor in a broken state with no visible spec.A
correctInvalidNavigationaction has been added toNavigationStorethat trims the navigation path back to the deepest level that still resolves to a valid spec. A MobXreactioninuseSpecLifecyclewatches for this condition and triggers the correction automatically whenever it occurs.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Screen Recording 2026-04-22 at 10.47.29 PM.mov (uploaded via Graphite)
Test Instructions
Additional Comments
The
disposeNavGuardcleanup is registered alongside the existingdisposeTaskWatcherto ensure the reaction is torn down properly when the editor unmounts.