fix(tests): Fix test timeouts and add early failure detection#21
Merged
fix(tests): Fix test timeouts and add early failure detection#21
Conversation
Prevents CI from timing out after 30 minutes when emulator fails to start. Changes: - Change all script shebangs from sh to bash for reproducibility - Add early failure detection in test suites (30s timeout) - Add timeout wrapper to cleanup processes (10s max) - Prevent cleanup from hanging on adb/xcrun when devices don't exist - Make deploy-app fail fast when emulator boot fails Timeline before fix: - verify-emulator-ready: waits 30 minutes - cleanup-app: hangs indefinitely on adb - Total: 30+ minute timeout Timeline after fix: - verify-emulator-ready: detects failure in 30s - deploy-app: fails immediately - cleanup-app: skips adb, exits in <1s - Total: ~35 seconds Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of split from #17. Prevents CI from timing out after 30 minutes when emulator fails to start.
Size: 335 lines (28 files, mostly one-line shebang changes)
Changes
Impact
Before: CI hangs for 30 minutes waiting for non-existent emulator
After: Fails fast in ~35 seconds with clear error messages
Related PRs
Part of 6-PR split of #17:
All PRs are independent.