fix(android): Fix device filtering and update min device to API 24#22
Merged
fix(android): Fix device filtering and update min device to API 24#22
Conversation
This was referenced Apr 21, 2026
abueide
force-pushed
the
fix/device-filtering-logic
branch
from
ae8336b to
f01087d
Compare
Fixes device filtering logic to properly respect ANDROID_DEVICES env var and updates minimum Android API from 21 to 24. Changes: - Add filename metadata to device definitions for filtering - Filter devices by filename in devices.sh and avd.sh - Add early failure detection when all devices are filtered out - Update min device from API 21 to API 24 (React Native minimum) - Update test validation to check for pixel_api24 Before: ANDROID_DEVICES=max would fail to match devices After: ANDROID_DEVICES=max correctly matches max.json device Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
abueide
force-pushed
the
fix/device-filtering-logic
branch
from
f01087d to
d633046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of split from #17. Fixes device filtering to properly respect ANDROID_DEVICES env var.
Size: 406 lines (6 files)
Changes
Impact
Before:
ANDROID_DEVICES=maxwould fail to match devicesAfter:
ANDROID_DEVICES=maxcorrectly matches max.json deviceRelated PRs
Part of 6-PR split of #17:
All PRs are independent.